Merged
Conversation
Girgias
approved these changes
Jan 9, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Sure, I didn't even know you could save PhD state.
lacatoire
reviewed
Jan 9, 2026
| public string $phpwebSourcesFilename = ''; | ||
| public string $phpwebHistoryFilename = ''; | ||
|
|
||
| private const NON_SERIALIZABLE_PROPERTIES = [ |
Contributor
There was a problem hiding this comment.
Suggested change
| private const NON_SERIALIZABLE_PROPERTIES = [ | |
| private const array NON_SERIALIZABLE_PROPERTIES = [ |
Contributor
Author
There was a problem hiding this comment.
Type class constants are PHP 8.3+ I think and Phd is supposed to be on 8.1+ currently. We could add types for all constants in a separate PR if @Girgias thinks we can bump to 8.3 or 8.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225 by preventing the serialization and deserialization of non-serializable properties. This could have been achieved with a reflection based approach but using a simple list is a good enough solution.